[PATCH] [mips] Always clobber $1 for MIPS inline asm.

Toma Tabacu Toma.Tabacu at imgtec.com
Thu Jan 8 02:35:24 PST 2015


-----Original Message-----
From: Daniel Sanders 
Sent: 07 January 2015 16:34
To: reviews+D6638+public+9dbc664d9cbf7b31 at reviews.llvm.org; Toma Tabacu
Cc: cfe-commits at cs.uiuc.edu
Subject: RE: [PATCH] [mips] Always clobber $1 for MIPS inline asm.

> Toma: Could you add a suitable comment to getClobbers()?

Yes, I will.
I'll also add a comment to MipsAsmPrinter::emitInlineAsmStart to explain why we push .set at,macro,reorder at the beginning of an inline asm block and
then pop them at the end (this was added in the LLVM patch).

Regards,
Toma Tabacu




More information about the cfe-commits mailing list