r225435 - clang-format: Improve template parameter detection.
Daniel Jasper
djasper at google.com
Thu Jan 8 00:48:22 PST 2015
Author: djasper
Date: Thu Jan 8 02:48:21 2015
New Revision: 225435
URL: http://llvm.org/viewvc/llvm-project?rev=225435&view=rev
Log:
clang-format: Improve template parameter detection.
Before:
struct A < std::enable_if<sizeof(T2) <sizeof(int32)>::type>;
After:
struct A<std::enable_if<sizeof(T2) < sizeof(int32)>::type>;
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=225435&r1=225434&r2=225435&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Thu Jan 8 02:48:21 2015
@@ -470,9 +470,12 @@ private:
return false;
break;
case tok::less:
- if ((!Tok->Previous || !Tok->Previous->Tok.isLiteral()) && parseAngle())
+ if ((!Tok->Previous ||
+ (!Tok->Previous->Tok.isLiteral() &&
+ !(Tok->Previous->is(tok::r_paren) && Contexts.size() > 1))) &&
+ parseAngle()) {
Tok->Type = TT_TemplateOpener;
- else {
+ } else {
Tok->Type = TT_BinaryOperator;
CurrentToken = Tok;
next();
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=225435&r1=225434&r2=225435&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Thu Jan 8 02:48:21 2015
@@ -4939,6 +4939,7 @@ TEST_F(FormatTest, UnderstandsTemplatePa
verifyFormat("f<int>();");
verifyFormat("template <typename T> void f() {}");
+ verifyFormat("struct A<std::enable_if<sizeof(T2) < sizeof(int32)>::type>;");
// Not template parameters.
verifyFormat("return a < b && c > d;");
More information about the cfe-commits
mailing list