[PATCH] [libcxx] Obey 29.6.5.21 for GCC.

Marshall Clow mclow.lists at gmail.com
Tue Jan 6 10:28:10 PST 2015


LGTM.


================
Comment at: include/atomic:650
@@ -639,3 +649,3 @@
                                       memory_order __order) {
-  return __atomic_store(&__a->__a_value, &__val,
-                        __gcc_atomic::__to_gcc_order(__order));
+  __atomic_store(&__a->__a_value, &__val,
+                 __gcc_atomic::__to_gcc_order(__order));
----------------
it's perfectly fine to return the result of a void function (from a function returning void)

http://reviews.llvm.org/D6632

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list