[PATCH] Clang-format: Braces Indent Style Whitesmith

JVApen JVApen at gmail.com
Mon Jan 5 09:22:20 PST 2015


I'm gonna assume you guys now the code base better then I do :p
By just indenting the braces, its gonna most likely be much cleaner code,
though then all code in UnwrappedLineParser will be the exact same for
Allman and Whitesmiths.
Any ideas how to make sure this will stay in sync in the future?

Anyhow, for now I'm gonna play a bit more with the code trying to do it the
'easy way' and get familiar with the code some more.
It won't hurt since I've noticed that I also need another feature to be
compliant with our current style sheet.
If it wouldn't work out I'll send a cry and otherwise a patch.


JVApen


On 5 January 2015 at 14:11, Daniel Jasper <djasper at google.com> wrote:

> I agree that that should lead to an way simpler implementation. It has the
> downside of spreading the brace handling stuff more outside of the
> UnwrappedLineParser, but that is probably ok in this case.
>
> So, we should remove almost all the changes to the UnwrappedLineParser and
> instead modify UnwrappedLineFormatter::formatFirstToken(). JVApen, can you
> make those changes? Alternatively, I can also pick up and finish the patch.
>
>
> http://reviews.llvm.org/D6833
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150105/230dd672/attachment.html>


More information about the cfe-commits mailing list