r225161 - clang-format: [Java] Fix incorrect detection of cast.
Daniel Jasper
djasper at google.com
Mon Jan 5 02:33:39 PST 2015
Author: djasper
Date: Mon Jan 5 04:33:39 2015
New Revision: 225161
URL: http://llvm.org/viewvc/llvm-project?rev=225161&view=rev
Log:
clang-format: [Java] Fix incorrect detection of cast.
After:
return (a instanceof List<?>) ? aaaaaaaaaaaaaaaaaaaaaaa(
aaaaaaaaaaaaaaaaaaaaa)
: aaaaaaaaaaaaaaaaaaaaaaa;
After:
return (a instanceof List<?>)
? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)
: aaaaaaaaaaaaaaaaaaaaaaa;
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJava.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=225161&r1=225160&r2=225161&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Mon Jan 5 04:33:39 2015
@@ -927,6 +927,8 @@ private:
LeftOfParens->MatchingParen->is(TT_LambdaLSquare))
return false;
if (Tok.Next) {
+ if (Tok.Next->is(tok::question))
+ return false;
if (Style.Language == FormatStyle::LK_JavaScript &&
Tok.Next->is(Keywords.kw_in))
return false;
Modified: cfe/trunk/unittests/Format/FormatTestJava.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJava.cpp?rev=225161&r1=225160&r2=225161&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTestJava.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTestJava.cpp Mon Jan 5 04:33:39 2015
@@ -289,6 +289,10 @@ TEST_F(FormatTestJava, Generics) {
verifyFormat("private Foo<X, Y>[] foos;");
verifyFormat("Foo<X, Y>[] foos = this.foos;");
+ verifyFormat("return (a instanceof List<?>)\n"
+ " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
+ " : aaaaaaaaaaaaaaaaaaaaaaa;",
+ getStyleWithColumns(60));
verifyFormat(
"SomeLoooooooooooooooooooooongType name =\n"
More information about the cfe-commits
mailing list