r224835 - Initialize CodeGeneratorImpl::Ctx in constructor.

[David Blaikie]

Any particular reason? It's sometimes handy to leave things uninitialized
if they stents intended to be read until after some other write - in that
way, msan can catch bugs when that constraint is violated.
On Dec 25, 2014 3:41 AM, "Yaron Keren" <yaron.keren at gmail.com> wrote:

> Author: yrnkrn
> Date: Thu Dec 25 05:38:15 2014
> New Revision: 224835
>
> URL: http://llvm.org/viewvc/llvm-project?rev=224835&view=rev
> Log:
> Initialize CodeGeneratorImpl::Ctx in constructor.
>
>
> Modified:
>     cfe/trunk/lib/CodeGen/ModuleBuilder.cpp
>
> Modified: cfe/trunk/lib/CodeGen/ModuleBuilder.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/ModuleBuilder.cpp?rev=224835&r1=224834&r2=224835&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/ModuleBuilder.cpp (original)
> +++ cfe/trunk/lib/CodeGen/ModuleBuilder.cpp Thu Dec 25 05:38:15 2014
> @@ -59,7 +59,7 @@ namespace {
>      CodeGeneratorImpl(DiagnosticsEngine &diags, const std::string&
> ModuleName,
>                        const CodeGenOptions &CGO, llvm::LLVMContext& C,
>                        CoverageSourceInfo *CoverageInfo = nullptr)
> -      : Diags(diags), CodeGenOpts(CGO), HandlingTopLevelDecls(0),
> +      : Diags(diags), Ctx(nullptr), CodeGenOpts(CGO),
> HandlingTopLevelDecls(0),
>          CoverageInfo(CoverageInfo),
>          M(new llvm::Module(ModuleName, C)) {}
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141225/c6342bed/attachment.html>