[PATCH] [libcxx] Teach libcxx's lit configuration new ways to find lit.site.cfg
Eric Fiselier
eric at efcs.ca
Fri Dec 19 11:07:59 PST 2014
================
Comment at: test/lit.cfg:589
@@ +588,3 @@
+ lit_config.load_config(config, site_cfg)
+ raise SystemExit
+
----------------
EricWF wrote:
> danalbert wrote:
> > You're actually raising a class here, not an exception. This would catch on `except type as ex` rather than `except SystemExit as ex` :)
> Thanks! This needs to be fixed in Clang's `lit.cfg` as well.
Actually I think we are both wrong. `raise SystemExit` seems to be equivalent to `raise SystemExit()`. If any arguments are added then `lit.TestingConfig.load_from_path` will exit before running any of the tests. I'll add the braces for clarity.
https://github.com/llvm-mirror/llvm/blob/master/utils/lit/lit/TestingConfig.py#L99
http://reviews.llvm.org/D6255
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list