[PATCH] Add -fno-modules-implicit-builds.

Manuel Klimek klimek at google.com
Thu Dec 18 06:14:20 PST 2014


The only thing not done is the renaming of the modules-implicit-maps flag, which I'd like to do in a separate patch.


================
Comment at: docs/Modules.rst:213-214
@@ -212,1 +212,4 @@
 
+``-fno-modules-implicit-bulids``
+  All modules used by the build must be specified with ``-fmodule-file``.
+
----------------
rsmith wrote:
> Please also add documentation for `-fmodule-file` if you're going to reference it from here. =)
Done.

================
Comment at: include/clang/Basic/DiagnosticCommonKinds.td:84-85
@@ -83,2 +83,4 @@
 def err_module_not_built : Error<"could not build module '%0'">, DefaultFatal;
+def err_module_build_disabled: Error<
+  "module '%0' not found, but module build was disabled">, DefaultFatal;
 def err_module_lock_failure : Error<
----------------
rsmith wrote:
> This seems like the wrong message to produce -- the problem here is that the module *was* found in some loaded module map file, but a prebuilt form of that module was not provided.
Better?

http://reviews.llvm.org/D6707

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list