[PATCH] [libcxx] Allow the use of ccache when running the test suite.

Jonathan Roelofs jonathan at codesourcery.com
Sat Dec 13 09:48:27 PST 2014


If the compiler changes on every iteration of the buildbot, how will ccache make that faster?

Also, ccache makes me a bit uncomfortable in a buildbot kind of environment. It's great for development, but it definitely adds one more area for build hysteresis. Perhaps we ought to have nightly (or whatever appropriate frequency) clean builds in addition to such a ccache bot.

All of that being said, this is awesome. LGTM.


================
Comment at: test/lit.cfg:122
@@ +121,3 @@
+    def _compile_and_link(self, exec_path, source_path):
+        object_file = tempfile.NamedTemporaryFile(suffix=".o", delete=False)
+        object_path = object_file.name
----------------
it'd be nice if this named temporary had something in common with the test file name.

http://reviews.llvm.org/D6647

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list