r224145 - Allow module deps to be printed in an arbitrary order

[Richard Smith]

On 12 Dec 2014 11:24, "Justin Bogner" <mail at justinbogner.com> wrote:
>
> Reid Kleckner <reid at kleckner.net> writes:
> > Author: rnk
> > Date: Fri Dec 12 13:13:04 2014
> > New Revision: 224145
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=224145&view=rev
> > Log:
> > Allow module deps to be printed in an arbitrary order
> >
> > The order is different between Windows and Unix for reasons unknown, but
> > the compiler output appears to still be determinstic.
>
> I don't think this is right. It looks to me like r224055 changed
> ModuleDependencyListener's semantics unintentionally. I'll look into it.

Thankyou!

I think the change you're referring to is that it removed the pruning of
/x/../. That was not unintentional - there were no tests for that
behaviour, and it's wrong if x is a symlink - but I had intended to
investigate further prior to checkin and forgot.

You should be about to revert the changes to ModuleDependecyCollector.cpp
to get back the old behaviour, but that behaviour seems to be wrong (and
will probably assert in some cases).

> > Modified:
> >     cfe/trunk/test/Modules/dependency-dump.m
> >
> > Modified: cfe/trunk/test/Modules/dependency-dump.m
> > URL:
> >
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/dependency-dump.m?rev=224145&r1=224144&r2=224145&view=diff
> >
==============================================================================
> > --- cfe/trunk/test/Modules/dependency-dump.m (original)
> > +++ cfe/trunk/test/Modules/dependency-dump.m Fri Dec 12 13:13:04 2014
> > @@ -6,10 +6,10 @@
> >  // expected-no-diagnostics
> >
> >  // RUN: FileCheck %s -check-prefix=VFS -input-file %t/vfs/vfs.yaml
> > -// VFS: 'name': "SubFramework.h"
> > -// VFS: 'name': "Treasure.h"
> > -// VFS: 'name': "Module.h"
> > -// VFS: 'name': "Sub.h"
> > -// VFS: 'name': "Sub2.h"
> > +// VFS-DAG: 'name': "SubFramework.h"
> > +// VFS-DAG: 'name': "Treasure.h"
> > +// VFS-DAG: 'name': "Module.h"
> > +// VFS-DAG: 'name': "Sub.h"
> > +// VFS-DAG: 'name': "Sub2.h"
> >
> >  @import Module;
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141212/c3ac8054/attachment.html>