[PATCH] [LIT] Allow suite configs to be preloaded allowing for better support of out-of-dir builds.

Daniel Dunbar daniel at zuster.org
Tue Dec 9 19:52:47 PST 2014


I sympathize with the use case, and in fact if you look at LLVM and Clang's
config files they have code which tries to do a trick where if it finds it
is running in the source without a lit.site.cfg, then it tries to infer the
location of the actual exec_root by seeing if you are the kind of user who
puts such things in your path. It's messy and only works for some users and
is complicated, so I'm ultimately not a big fan of that solution, but it
was the first thing I came up with.

The next thing I came up with was the idea of building a tool that baked in
the path to the config file, that is llvm-lit. I'm not all that happy with
that approach either.r

Why did you decide you didn't like this patch?

 - Daniel


On Tue, Dec 9, 2014 at 11:59 AM, Eric Fiselier <eric at efcs.ca> wrote:

> I really don't like this patch. There was some suggestion that this
> feature would go nicely is LIT but I think it's better implemented on a
> test-suite basis.
>
> http://reviews.llvm.org/D6275
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141209/10f15fe8/attachment.html>


More information about the cfe-commits mailing list