[PATCH] [libcxx] Consolidate new/delete replacement in tests and disable it when using sanitizers.

Jonathan Roelofs jonathan at codesourcery.com
Tue Dec 9 15:26:03 PST 2014


Looks good to me.

================
Comment at: test/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp:27
@@ -26,3 @@
-    ++new_called;
-    assert(s == 3 * sizeof(int));
-    return std::malloc(s);
----------------
EricWF wrote:
> jroelofs wrote:
> > I think we're losing test coverage now that this assert is gone :(
> We shouldn't be. I added assertions on line 38 and line 47 that check the same thing.
Oh, I missed that.

http://reviews.llvm.org/D6562






More information about the cfe-commits mailing list