[PATCH] Rename preprocessor symbols to be more descriptive. NFC

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Dec 5 21:07:27 PST 2014

r223578, thanks!

From: metafoo at gmail.com [mailto:metafoo at gmail.com] On Behalf Of Richard Smith
Sent: Friday, December 05, 2014 5:15 PM
To: Jordan Rose
Cc: Robinson, Paul; cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH] Rename preprocessor symbols to be more descriptive. NFC


On Fri, Dec 5, 2014 at 4:35 PM, Jordan Rose <jordan_rose at apple.com<mailto:jordan_rose at apple.com>> wrote:
+1 from me, and I like the name choice.

> On Dec 5, 2014, at 15:41, Robinson, Paul <Paul_Robinson at playstation.sony.com<mailto:Paul_Robinson at playstation.sony.com>> wrote:
> This seemed a *little* too intricate to commit directly even if it is NFC.
> Also gives everyone a chance to disagree with the name choices. :-)
> This is a followup to a GetSVN.cmake change; Sean Silva and Jordan Rose
> asked to have the name of the SVN_REVISION/SVN_REPOSITORY symbols changed.
> This requires changing both the Makefile and CMakeLists.txt so they both
> generate the same symbol name, and Version.cpp which is the only consumer.
> The header generated by CMakeLists.txt/GetSVN.cmake used to look like this:
> #define LLVM_REVISION "223538"
> #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
> #define SVN_REVISION "223538"
> #define SVN_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"
> and now looks like this:
> #define LLVM_REVISION "223538"
> #define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
> #define CLANG_REVISION "223538"
> #define CLANG_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"
> --paulr
> <svn_revision.diff>

cfe-commits mailing list
cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141206/d94c750d/attachment.html>

More information about the cfe-commits mailing list