[PATCH] Rename preprocessor symbols to be more descriptive. NFC

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Dec 5 15:41:33 PST 2014

This seemed a *little* too intricate to commit directly even if it is NFC.
Also gives everyone a chance to disagree with the name choices. :-)

This is a followup to a GetSVN.cmake change; Sean Silva and Jordan Rose
asked to have the name of the SVN_REVISION/SVN_REPOSITORY symbols changed.
This requires changing both the Makefile and CMakeLists.txt so they both
generate the same symbol name, and Version.cpp which is the only consumer.

The header generated by CMakeLists.txt/GetSVN.cmake used to look like this:

#define LLVM_REVISION "223538"
#define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
#define SVN_REVISION "223538"
#define SVN_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"

and now looks like this:

#define LLVM_REVISION "223538"
#define LLVM_REPOSITORY "http://llvm.org/svn/llvm-project/llvm/trunk"
#define CLANG_REVISION "223538"
#define CLANG_REPOSITORY "http://llvm.org/svn/llvm-project/cfe/trunk"

-------------- next part --------------
A non-text attachment was scrubbed...
Name: svn_revision.diff
Type: application/octet-stream
Size: 2970 bytes
Desc: svn_revision.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141205/2d5dce8f/attachment.obj>

More information about the cfe-commits mailing list