[PATCH] Workaround attribute ordering issue with kernel only attributes

Aaron Ballman aaron.ballman at gmail.com
Thu Dec 4 18:44:03 PST 2014

On Thu, Dec 4, 2014 at 6:30 PM, Matt Arsenault
<Matthew.Arsenault at amd.com> wrote:
> Hi aaron.ballman,
> Placing the attribute after the kernel keyword would incorrectly
> reject the attribute, so use the smae workaround that other
> kernel only attributes use.
> Also add a FIXME because there are two different phrasings now
> for the same error, althoug amdgpu_num_[sv]gpr uses a consistent one.

LGTM! Thanks!


> http://reviews.llvm.org/D6542
> Files:
>   include/clang/Basic/Attr.td
>   lib/Sema/SemaDeclAttr.cpp
>   test/SemaCUDA/amdgpu-num-gpr-attr.cu
>   test/SemaOpenCL/amdgpu-num-register-attrs.cl

More information about the cfe-commits mailing list