r220714 - Frontend: Define __EXCEPTIONS if -fexceptions is passed

Hans Wennborg hans at chromium.org
Thu Dec 4 16:14:00 PST 2014


On Mon, Oct 27, 2014 at 1:02 PM, David Majnemer
<david.majnemer at gmail.com> wrote:
> Author: majnemer
> Date: Mon Oct 27 15:02:19 2014
> New Revision: 220714


This broke Chromium:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/11730/steps/compile%20%28with%20patch%29/logs/stdio

> --- cfe/trunk/test/Preprocessor/predefined-exceptions.m (original)
> +++ cfe/trunk/test/Preprocessor/predefined-exceptions.m Mon Oct 27 15:02:19 2014
> @@ -1,6 +1,6 @@
>  // RUN: %clang_cc1 -x objective-c -fobjc-exceptions -fexceptions -E -dM %s | FileCheck -check-prefix=CHECK-OBJC-NOCXX %s
>  // CHECK-OBJC-NOCXX: #define OBJC_ZEROCOST_EXCEPTIONS 1
> -// CHECK-OBJC-NOCXX-NOT: #define __EXCEPTIONS 1
> +// CHECK-OBJC-NOCXX: #define __EXCEPTIONS 1

It seems this reverses the test, and does the opposite of what at
least the code I was trying to compile with -fno-exceptions expects:
https://code.google.com/p/chromium/codesearch#chromium/src/breakpad/src/client/mac/Framework/Breakpad.mm&l=51



More information about the cfe-commits mailing list