[PATCH] CodeGen: implement __emit intrinsic

David Majnemer david.majnemer at gmail.com
Thu Dec 4 15:30:41 PST 2014


================
Comment at: lib/Basic/Builtins.cpp:58-61
@@ -57,4 +57,6 @@
                             (BuiltinInfo.builtin_lang & GNU_LANG);
   bool MSModeUnsupported = !LangOpts.MicrosoftExt &&
                            (BuiltinInfo.builtin_lang & MS_LANG);
+  bool MSCompatUnsupported = !LangOpts.MSVCCompat &&
+                             (BuiltinInfo.builtin_lang & MS_MODE);
   bool ObjCUnsupported = !LangOpts.ObjC1 &&
----------------
abdulras wrote:
> majnemer wrote:
> > `MSModeUnsupported` uses `MS_LANG` and `MSCompatUnsupported` uses `MS_MODE`.  That's a little confusing.
> I'm more than happy to rename this to a better name.  Would you prefer MSVC_COMPAT?  MSVC_MODE?  MSC_COMPAT?  MSC_MODE?
Renaming MS_MODE to MS_COMPAT seems reasonable.

http://reviews.llvm.org/D3489






More information about the cfe-commits mailing list