[PATCH] Recognize __unaligned in more cases

Aaron Ballman aaron at aaronballman.com
Thu Dec 4 14:40:13 PST 2014


On Thu, Dec 4, 2014 at 4:54 PM, Nico Rieck <nico.rieck at gmail.com> wrote:
> On 29.11.2014 17:46, Aaron Ballman wrote:
>> This should be in the IgnoredAttributes warning group.
>> [...]
>> I think the usual pattern for this is to make a Skip function that
>> parses and skips attribtues (returning the end location), and a
>> DiagnoseAndSkip which diagnoses if any attributes were skipped. We may
>> not need the separation, but it would be good to keep the
>> nomenclature.
>
> Done. And diagnosing a range does indeed look better than emitting
> several warnings. :)

LGTM! Thanks!

~Aaron



More information about the cfe-commits mailing list