r223234 - clang-format: Fix fake parentheses placement with comments.
Daniel Jasper
djasper at google.com
Wed Dec 3 06:02:59 PST 2014
Author: djasper
Date: Wed Dec 3 08:02:59 2014
New Revision: 223234
URL: http://llvm.org/viewvc/llvm-project?rev=223234&view=rev
Log:
clang-format: Fix fake parentheses placement with comments.
Before:
return (a > b
// comment1
// comment2
|| c);
After:
return (a > b
// comment1
// comment2
|| c);
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=223234&r1=223233&r2=223234&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Wed Dec 3 08:02:59 2014
@@ -1217,7 +1217,7 @@ private:
Start->StartsBinaryExpression = true;
if (Current) {
FormatToken *Previous = Current->Previous;
- if (Previous->is(tok::comment) && Previous->Previous)
+ while (Previous->is(tok::comment) && Previous->Previous)
Previous = Previous->Previous;
++Previous->FakeRParens;
if (Precedence > prec::Unknown)
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=223234&r1=223233&r2=223234&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Wed Dec 3 08:02:59 2014
@@ -3337,6 +3337,13 @@ TEST_F(FormatTest, NoOperandAlignment) {
" + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n"
" * cccccccccccccccccccccccccccccccccccc;",
Style);
+
+ Style.AlignAfterOpenBracket = false;
+ verifyFormat("return (a > b\n"
+ " // comment1\n"
+ " // comment2\n"
+ " || c);",
+ Style);
}
TEST_F(FormatTest, BreakingBeforeNonAssigmentOperators) {
More information about the cfe-commits
mailing list