[PATCH] Skip some unnecessary type checks.

Manuel Klimek klimek at google.com
Tue Dec 2 00:44:01 PST 2014


================
Comment at: include/clang/AST/ASTTypeTraits.h:264
@@ -253,4 +263,3 @@
   bool operator==(const DynTypedNode &Other) const {
-    if (!NodeKind.isBaseOf(Other.NodeKind) &&
-        !Other.NodeKind.isBaseOf(NodeKind))
+    if (!NodeKind.isSame(Other.NodeKind))
       return false;
----------------
Why doesn't this change behavior? -> can we not get the same node with a different more or less specific type?

http://reviews.llvm.org/D6468






More information about the cfe-commits mailing list