[PATCH] [clang][MIPS] Removing __SIZEOF_INT128__ macro for MIPS64

Simon Atanasyan simon at atanasyan.com
Fri Nov 28 02:14:30 PST 2014


LGTM with the only nit.

REPOSITORY
  rL LLVM

================
Comment at: lib/Frontend/InitPreprocessor.cpp:665
@@ -664,2 +664,3 @@
                    TI.getTypeWidth(TI.getWIntType()), TI, Builder);
-  if (TI.hasInt128Type())
+  if (TI.hasInt128Type() && !(TI.getTriple().getArch() == llvm::Triple::mips64el
+                   || TI.getTriple().getArch() == llvm::Triple::mips64))
----------------
I would add a comment describes that it is a temporary workaround while MIPS has no fully supported 128-bit integers and we do not want to get an error from limit.h.

http://reviews.llvm.org/D6402






More information about the cfe-commits mailing list