[PATCH] Fix DiagnosticErrorTrap with SuppressAllDiagnostics

Richard Smith richard at metafoo.co.uk
Tue Nov 25 18:33:58 PST 2014


On Tue, Nov 25, 2014 at 12:12 PM, Brad King <brad.king at kitware.com> wrote:

> Hi Folks,
>
> On 11/20/2014 09:27 AM, Brad King wrote [1]:
> > SuppressAllDiagnostics prevents DiagnosticErrorTrap from working
> > so any analysis in Clang that uses traps fails to work correctly.
>
> Here is a patch that fixes this problem and adds a test covering the
> use case.  See commit message in the patch file for details.  I've
> tested it on r222772.
>

Patch LGTM, thanks. Do you need someone to commit this for you?

Thanks,
> -Brad
>
> [1]
> http://thread.gmane.org/gmane.comp.compilers.clang.scm/110832/focus=112180
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141125/4fec7ffd/attachment.html>


More information about the cfe-commits mailing list