[PATCH] pr21217 - -fmodule-map-file should warn on non-existent file

John Thompson john.thompson.jtsoftware at gmail.com
Mon Nov 24 18:00:19 PST 2014


Sorry, I missed the hard tab, braces, and etc.  However, if I remove the clearing of the ModuleMapFiles member, one of the tests, Modules/modular_maps.cpp segfaults deep in some AST code, but only on running the test on Linux, so it's kind of hard to debug, not being much of a Linux/gdb guy.  Did I put this code in the right place?  I was kind of uncomfortable putting it in the HeaderSearch constructor, but it is a convenient place, since HeaderSearch has convenient members.  I don't see any other references to the ModuleMapFiles member, so I'm not sure what triggers the segfault only on Linux, unless it's some memory-stomping or post-free-write issue somewhere.

http://reviews.llvm.org/D6324

Files:
  include/clang/Basic/DiagnosticLexKinds.td
  lib/Lex/HeaderSearch.cpp
  test/Modules/pr21217.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6324.16591.patch
Type: text/x-patch
Size: 3020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141125/3e5e1c8c/attachment.bin>


More information about the cfe-commits mailing list