[PATCH] PR21604: Correctly remove OptimizeForSize from OptimizeNone functions

Robinson, Paul Paul_Robinson at playstation.sony.com
Mon Nov 24 09:55:22 PST 2014


Ping. Aaron, could you PTAL?
--paulr

> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Robinson, Paul
> Sent: Wednesday, November 19, 2014 5:22 PM
> To: cfe-commits at cs.uiuc.edu
> Subject: [PATCH] PR21604: Correctly remove OptimizeForSize from
> OptimizeNone functions
> 
> While it might have looked like OptimizeNone removed the OptimizeForSize
> attribute from a function, it weren't necessarily so.  This patch fixes
> the attribute handling so 'optnone' correctly supersedes all the other
> things it's supposed to supersede.
> 
> Updated a test to do a -Os run so we verify that part works right.
> Added a test to exercise different combinations of attributes on the
> declaration versus on the definition, which is another way that these
> things can end up having to be merged/untangled.
> --paulr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr21604.diff
Type: application/octet-stream
Size: 6376 bytes
Desc: pr21604.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141124/f6364c52/attachment.obj>


More information about the cfe-commits mailing list