[PATCH] Fix Itanium ABI for ARM

Weiming Zhao weimingz at codeaurora.org
Fri Nov 21 16:51:23 PST 2014


Hi rafael,

r218141 "In the Itanium ABI, move stuff to the comdat of variables with static init." causes gnu as crash for ARM in some cases:

foo.s: Assembler messages:
foo.s:208: Internal error!
Assertion failure in get_line_subseg at crosstool_linaro/src/crosstool-ng-linaro-1.13.1-4.8-2014.01/builds/arm-linux-gnueabi-linux/.build/src/binutils-linaro-2.24-2013.12/gas/dwarf2dbg.c line 271.

r218141 handles the comdat of varialbes for Itanium ABI. However, the routine is shared by both ARM and Itanium. 
It seems the change should be guarded to Itanium only.

http://reviews.llvm.org/D6366

Files:
  lib/CodeGen/ItaniumCXXABI.cpp
  test/CodeGenCXX/static-data-member.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6366.16519.patch
Type: text/x-patch
Size: 1576 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141122/16fd1dca/attachment.bin>


More information about the cfe-commits mailing list