[clang-tools-extra] r222431 - [clang-tidy] Set google-readability-namespace-comments.ShortNamespaceLines to 10

[Alexander Kornienko]

Author: alexfh
Date: Thu Nov 20 09:05:32 2014
New Revision: 222431

URL: http://llvm.org/viewvc/llvm-project?rev=222431&view=rev
Log:
[clang-tidy] Set google-readability-namespace-comments.ShortNamespaceLines to 10

This value is used in cpplint, so we'd better be consistent.

Modified:
    clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp
    clang-tools-extra/trunk/test/clang-tidy/google-module.cpp
    clang-tools-extra/trunk/test/clang-tidy/google-readability-namespace-comments.cpp

Modified: clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp?rev=222431&r1=222430&r2=222431&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp Thu Nov 20 09:05:32 2014
@@ -72,7 +72,7 @@ public:
     Opts["google-readability-braces-around-statements.ShortStatementLines"] =
         "1";
     Opts["google-readability-function-size.StatementThreshold"] = "800";
-    Opts["google-readability-namespace-comments.ShortNamespaceLines"] = "1";
+    Opts["google-readability-namespace-comments.ShortNamespaceLines"] = "10";
     Opts["google-readability-namespace-comments.SpacesBeforeComments"] = "2";
     return Options;
   }

Modified: clang-tools-extra/trunk/test/clang-tidy/google-module.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/google-module.cpp?rev=222431&r1=222430&r2=222431&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/google-module.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/google-module.cpp Thu Nov 20 09:05:32 2014
@@ -5,6 +5,6 @@
 // CHECK: {{- key: *google-readability-function-size.StatementThreshold}}
 // CHECK-NEXT: {{value: *'800'}}
 // CHECK: {{- key: *google-readability-namespace-comments.ShortNamespaceLines}}
-// CHECK-NEXT: {{value: *'1'}}
+// CHECK-NEXT: {{value: *'10'}}
 // CHECK: {{- key: *google-readability-namespace-comments.SpacesBeforeComments}}
 // CHECK-NEXT: {{value: *'2'}}

Modified: clang-tools-extra/trunk/test/clang-tidy/google-readability-namespace-comments.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/google-readability-namespace-comments.cpp?rev=222431&r1=222430&r2=222431&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/google-readability-namespace-comments.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/google-readability-namespace-comments.cpp Thu Nov 20 09:05:32 2014
@@ -3,14 +3,28 @@
 
 namespace n1 {
 namespace n2 {
+
+
+
+
+
 // CHECK-MESSAGES: :[[@LINE+4]]:2: warning: namespace 'n2' not terminated with a closing comment [google-readability-namespace-comments]
-// CHECK-MESSAGES: :[[@LINE-2]]:11: note: namespace 'n2' starts here
+// CHECK-MESSAGES: :[[@LINE-7]]:11: note: namespace 'n2' starts here
 // CHECK-MESSAGES: :[[@LINE+3]]:2: warning: namespace 'n1' not terminated with
-// CHECK-MESSAGES: :[[@LINE-5]]:11: note: namespace 'n1' starts here
+// CHECK-MESSAGES: :[[@LINE-10]]:11: note: namespace 'n1' starts here
 }
 }
 // CHECK-FIXES: }  // namespace n2
 // CHECK-FIXES: }  // namespace n1
 
 
-namespace short1 { namespace short2 { } }
+namespace short1 {
+namespace short2 {
+// Namespaces covering 10 lines or fewer are exempt from this rule.
+
+
+
+
+
+}
+}