[PATCH] pr21217 - -fmodule-map-file should warn on non-existent file

Daniel Jasper djasper at google.com
Thu Nov 20 02:06:43 PST 2014


This basically looks good to me, but I'd like Richard to take a look, too.

================
Comment at: include/clang/Basic/DiagnosticLexKinds.td:615
@@ +614,3 @@
+def warn_module_map_not_found : Warning<
+  "File '%0' from -fmodule-map-file=%0 not found">,
+  InGroup<ModuleMapMissing>;
----------------
I'd phrase it as:

  "File '%0' specified via -fmodule-map-file not found"

================
Comment at: test/Modules/pr21217.cpp:6-8
@@ +5,4 @@
+
+#include "Inputs/private/common.h"
+
+void empty() {}
----------------
Do these serve any purpose?

http://reviews.llvm.org/D6324






More information about the cfe-commits mailing list