[PATCH] Mangling of member-expressions involving anonymous unions.
richard at metafoo.co.uk
Wed Nov 19 17:35:30 PST 2014
Committed as r222402. Thanks!
On Thu, Nov 13, 2014 at 9:47 PM, Tomasz Miąsko <tomasz.miasko at gmail.com>
> On czw, 2014-11-13 at 19:09 -0800, Richard Smith wrote:
> > On Thu, Nov 13, 2014 at 10:36 AM, Tomasz Miąsko
> > <tomasz.miasko at gmail.com> wrote:
> > Indeed, something like "if (!member) return
> > mangleExpression(base)", would be
> > really nice, but the problem is that we need a member name
> > from outermost
> > MemberExpr generated from IndirectFieldDecl, and isArrow from
> > innermost
> > MemberExpr generated from IndirectFieldDecl.
> > Good point =)
> > I updated the code to skip over all bases whose types are
> > anonymous structs or
> > unions, though I will mention that first version that relied
> > on empty
> > identifiers would also work.
> > Thanks, LGTM. Do you have an SVN account, or do you need someone to
> > commit this for you?
> I don't have commit access, could you commit this for me?
> > http://reviews.llvm.org/D5997
> > Files:
> > lib/AST/ItaniumMangle.cpp
> > test/CodeGenCXX/mangle-exprs.cpp
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits