[PATCH] Make DiagnosticsEngine::takeClient return std::unique_ptr<>

Alexander Kornienko alexfh at google.com
Mon Nov 17 09:07:37 PST 2014


Hi dblaikie,

Make DiagnosticsEngine::takeClient return std::unique_ptr<>. Updated
callers to store conditional ownership using a pair of pointer and unique_ptr
instead of a pointer + bool. Updated code that temporarily registers clients to
use the non-owning registration (+ removed extra calls to takeClient).

http://reviews.llvm.org/D6294

Files:
  include/clang/Basic/Diagnostic.h
  include/clang/Frontend/VerifyDiagnosticConsumer.h
  include/clang/Rewrite/Frontend/FixItRewriter.h
  lib/Basic/Diagnostic.cpp
  lib/Frontend/ASTUnit.cpp
  lib/Frontend/CompilerInstance.cpp
  lib/Frontend/Rewrite/FixItRewriter.cpp
  lib/Frontend/VerifyDiagnosticConsumer.cpp
  tools/driver/driver.cpp
  unittests/Sema/ExternalSemaSourceTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6294.16294.patch
Type: text/x-patch
Size: 10438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141117/1636e2ff/attachment.bin>


More information about the cfe-commits mailing list