[libcxx] r222076 - Split thread test into two parts. Mark one as XFAIL with ASAN.
Eric Fiselier
eric at efcs.ca
Fri Nov 14 17:58:45 PST 2014
Author: ericwf
Date: Fri Nov 14 19:58:45 2014
New Revision: 222076
URL: http://llvm.org/viewvc/llvm-project?rev=222076&view=rev
Log:
Split thread test into two parts. Mark one as XFAIL with ASAN.
The second part of the test checks that std::terminate is called when a running
thread is move assigned to. Calling std::terminate prevents some of the destructors
to be called and ASAN fires on this.
Added:
libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp
Modified:
libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp
Modified: libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp?rev=222076&r1=222075&r2=222076&view=diff
==============================================================================
--- libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp (original)
+++ libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move.pass.cpp Fri Nov 14 19:58:45 2014
@@ -16,8 +16,6 @@
// thread& operator=(thread&& t);
#include <thread>
-#include <new>
-#include <cstdlib>
#include <cassert>
class G
@@ -31,13 +29,6 @@ public:
G(const G& g) : alive_(g.alive_) {++n_alive;}
~G() {alive_ = 0; --n_alive;}
- void operator()()
- {
- assert(alive_ == 1);
- assert(n_alive >= 1);
- op_run = true;
- }
-
void operator()(int i, double j)
{
assert(alive_ == 1);
@@ -51,15 +42,9 @@ public:
int G::n_alive = 0;
bool G::op_run = false;
-void f1()
-{
- std::exit(0);
-}
-
int main()
{
#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
- std::set_terminate(f1);
{
assert(G::n_alive == 0);
assert(!G::op_run);
@@ -73,12 +58,5 @@ int main()
assert(G::n_alive == 0);
assert(G::op_run);
}
- {
- std::thread t0(G(), 5, 5.5);
- std::thread::id id = t0.get_id();
- std::thread t1;
- t0 = std::move(t1);
- assert(false);
- }
#endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES
}
Added: libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp?rev=222076&view=auto
==============================================================================
--- libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp (added)
+++ libcxx/trunk/test/thread/thread.threads/thread.thread.class/thread.thread.assign/move2.pass.cpp Fri Nov 14 19:58:45 2014
@@ -0,0 +1,75 @@
+//===----------------------------------------------------------------------===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// UNSUPPORTED: libcpp-has-no-threads
+
+// NOTE: std::terminate is called so the destructors are not invoked and the
+// memory is not freed. This will cause ASAN to fail.
+// XFAIL: asan
+
+// <thread>
+
+// class thread
+
+// thread& operator=(thread&& t);
+
+#include <thread>
+#include <exception>
+#include <cstdlib>
+#include <cassert>
+
+class G
+{
+ int alive_;
+public:
+ static int n_alive;
+ static bool op_run;
+
+ G() : alive_(1) {++n_alive;}
+ G(const G& g) : alive_(g.alive_) {++n_alive;}
+ ~G() {alive_ = 0; --n_alive;}
+
+ void operator()()
+ {
+ assert(alive_ == 1);
+ assert(n_alive >= 1);
+ op_run = true;
+ }
+
+ void operator()(int i, double j)
+ {
+ assert(alive_ == 1);
+ assert(n_alive >= 1);
+ assert(i == 5);
+ assert(j == 5.5);
+ op_run = true;
+ }
+};
+
+int G::n_alive = 0;
+bool G::op_run = false;
+
+void f1()
+{
+ std::exit(0);
+}
+
+int main()
+{
+#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
+ std::set_terminate(f1);
+ {
+ std::thread t0(G(), 5, 5.5);
+ std::thread::id id = t0.get_id();
+ std::thread t1;
+ t0 = std::move(t1);
+ assert(false);
+ }
+#endif // _LIBCPP_HAS_NO_RVALUE_REFERENCES
+}
More information about the cfe-commits
mailing list