[PATCH] Adding ID and Warning Option to Diagnostic Log

[Steven Wu]

committed in r222042

> On Nov 14, 2014, at 12:38 PM, Steven Wu <stevenwu at apple.com> wrote:
> 
> Ahh, right. Thanks! 
> 
>> On Nov 13, 2014, at 3:16 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
>> 
>> Isn’t the line I posted semantically equivalent to the snippet from the diff ?
>> If the StringRef returned from getWarningOptionForDiag is empty then the “WarningOption” string variable will be set to empty.
>> 
>>> On Nov 13, 2014, at 2:54 PM, Steven Wu <stevenwu at apple.com <mailto:stevenwu at apple.com>> wrote:
>>> 
>>> Not all Diagnostics are warnings and not all warnings has a flag. If the flag is not applicable, then this field is not generated.
>>> 
>>>> On Nov 13, 2014, at 2:47 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com <mailto:kyrtzidis at apple.com>> wrote:
>>>> 
>>>> DE.WarningOption = DiagnosticIDs::getWarningOptionForDiag(DE.DiagnosticID);
>>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits>
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141114/ac443776/attachment.html>