[modules][PATCH] Teach the ASTDeclReader to update the exception specs of the deserialized decl's redecl chain.

[Richard Smith]

+    }
+    else { // FPT->getExceptionSpecType() is resolved and the other is not

You're not checking for this condition; the code here is getting run even
if both or neither are unresolved.

The patch needs rebasing (we have a new helper function in ASTContext to
update the exception specification of a declaration), but looks like the
right direction.

On Thu, Nov 6, 2014 at 4:23 AM, Vassil Vassilev <
vasil.georgiev.vasilev at cern.ch> wrote:

> Hi Richard,
>   I am attaching the patch we discussed at the dev meeting. Still haven't
> found small reproducer...
>   The issue appears to stem from the fact that module A contains only a
> forward declaration of a function and it exception spec cannot be computed.
> In module B is the definition with computed exception spec, which gets
> deserialized after the one in module A. This patch teaches the
> ASTDeclReader to update all the exception specs of the previous decls to
> the current one.
>
>   Could you review, please?
> Many thanks,
> Vassil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141113/768f2476/attachment.html>