[PATCH] [clang-tidy] Move the missing namespace comment warnings to the closing brace

Alexander Kornienko alexfh at google.com
Thu Nov 13 08:36:02 PST 2014


Hi klimek,

The google-readability-namespace-comments/llvm-namespace-comment
warnings are quite confusing when they appear at the beginning of a long
namespace and the closing brace is not in sight.

For convenience added notes pointing to the start of the namespace.

http://reviews.llvm.org/D6251

Files:
  clang-tidy/readability/NamespaceCommentCheck.cpp
  test/clang-tidy/basic.cpp
  test/clang-tidy/google-readability-namespace-comments.cpp
  test/clang-tidy/select-checks.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6251.16162.patch
Type: text/x-patch
Size: 2962 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141113/b23c021d/attachment.bin>


More information about the cfe-commits mailing list