r221803 - Pass the filter function_ref by value now that r221753 fixes the bug

Kaelyn Takata rikka at google.com
Wed Nov 12 10:34:08 PST 2014


Author: rikka
Date: Wed Nov 12 12:34:08 2014
New Revision: 221803

URL: http://llvm.org/viewvc/llvm-project?rev=221803&view=rev
Log:
Pass the filter function_ref by value now that r221753 fixes the bug
that was preventing pass-by-value from working correctly.

Modified:
    cfe/trunk/lib/Sema/SemaExprCXX.cpp

Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=221803&r1=221802&r2=221803&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Wed Nov 12 12:34:08 2014
@@ -5989,8 +5989,8 @@ class TransformTypos : public TreeTransf
   }
 
 public:
-  TransformTypos(Sema &SemaRef, llvm::function_ref<ExprResult(Expr *)> &&Filter)
-      : BaseTransform(SemaRef), ExprFilter(std::move(Filter)) {}
+  TransformTypos(Sema &SemaRef, llvm::function_ref<ExprResult(Expr *)> Filter)
+      : BaseTransform(SemaRef), ExprFilter(Filter) {}
 
   ExprResult RebuildCallExpr(Expr *Callee, SourceLocation LParenLoc,
                                    MultiExprArg Args,
@@ -6075,7 +6075,7 @@ ExprResult Sema::CorrectDelayedTyposInEx
       (E->isTypeDependent() || E->isValueDependent() ||
        E->isInstantiationDependent())) {
     auto TyposResolved = DelayedTypos.size();
-    auto Result = TransformTypos(*this, std::move(Filter)).Transform(E);
+    auto Result = TransformTypos(*this, Filter).Transform(E);
     TyposResolved -= DelayedTypos.size();
     if (TyposResolved) {
       ExprEvalContexts.back().NumTypos -= TyposResolved;





More information about the cfe-commits mailing list