[PATCH] Forward -target-feature option through to assembler.

Charlie Turner charlie.turner at arm.com
Tue Nov 11 01:46:18 PST 2014


Hi Rafael,

> The command line of -cc1 and -cc1as is considered an implementation detail. It is just that clang forks a new process, so we have to invent something. I would agree that it is not a very nice interface, but that is more of a reason to keep it private :-)

Ah, then `clang ... -Wa,-mp` would be OK even if the implementation translated this to "clang -cc1as ... -target-feature -mp"? So the main objection was that you could pass -target-feature directly on the Clang command line? Makes sense now :)

I think my best way forward is to add a new flag such as -mnomp similar to the existing -mnocrc flag, rather than forwarding ARM specific target features through -Wa/-Xassembler. I'll prepare a new patch.

Thanks again for the review!
Charlie.







More information about the cfe-commits mailing list