[PATCH] [OPENMP] Codegen for threadprivate variables

John McCall rjmccall at gmail.com
Sat Nov 8 22:21:59 PST 2014


You never actually call DeclarationMarkedOpenMPThreadPrivate in the first place.  The right place to do that is at the point when you add the attribute.

You also need to test that this works.  The basic idea is that the first PCH file should declare the variable, the second should declare it to be thread-private, and the third uses it (in some way that verifies that it was marked thread-private; preferably using a Sema check, but an IRGen test is also okay).  You can look at test/PCH/chain-categories.m and test/PCH/chain-implicit-definition.cpp for examples of how to do that.  (The test should go in test/PCH, not test/OpenMP.)

http://reviews.llvm.org/D4002






More information about the cfe-commits mailing list