r221125 - clang-format: [Java] Allow trailing semicolons after enums.

Daniel Jasper djasper at google.com
Mon Nov 3 08:52:36 PST 2014


I meant removing the semicolon after Java enums, where they aren't
necessary.

On Mon, Nov 3, 2014 at 5:49 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 03.11.2014 16:53, Daniel Jasper wrote:
>
>> Reverted in r221158.
>>
>
> Thanks.
>
>  I think just removing the semicolon should be good
>> in almost all cases. We can reconsider later if that proves to be wrong.
>>
>
> Removing the semicolon from were? If I just drop it from the C++ code I
> get an error:
>
> /tmp/test.cpp:3:23: error: expected ';' after enum
> enum TestEnum2 { D, C}
>                       ^
>                       ;
>
> Are you saying there is a way I can change the C++ code such that
> clang-format will do the right thing even with this patch? Or are you
> talking about removing semicolons at another place (maybe ignoring them in
> clang-format?).
>
> I am mostly asking to understand if I can just put the check back in place
> or if I could also update some code to avoid issues in the future.
>
> Cheers,
> Tobias
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141103/e2ef02ed/attachment.html>


More information about the cfe-commits mailing list