r221124 - clang-format: [Java] Fix more generics formatting.
Daniel Jasper
djasper at google.com
Sun Nov 2 18:45:58 PST 2014
Author: djasper
Date: Sun Nov 2 20:45:58 2014
New Revision: 221124
URL: http://llvm.org/viewvc/llvm-project?rev=221124&view=rev
Log:
clang-format: [Java] Fix more generics formatting.
Before:
< T extends B > T getInstance(Class<T> type);
After:
<T extends B> T getInstance(Class<T> type);
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJava.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=221124&r1=221123&r2=221124&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Sun Nov 2 20:45:58 2014
@@ -472,7 +472,7 @@ private:
return false;
break;
case tok::less:
- if (Tok->Previous && !Tok->Previous->Tok.isLiteral() && parseAngle())
+ if ((!Tok->Previous || !Tok->Previous->Tok.isLiteral()) && parseAngle())
Tok->Type = TT_TemplateOpener;
else {
Tok->Type = TT_BinaryOperator;
Modified: cfe/trunk/unittests/Format/FormatTestJava.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJava.cpp?rev=221124&r1=221123&r2=221124&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTestJava.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTestJava.cpp Sun Nov 2 20:45:58 2014
@@ -143,6 +143,7 @@ TEST_F(FormatTestJava, Generics) {
"public Map<String, ?> getAll() {\n}");
verifyFormat("public static <R> ArrayList<R> get() {\n}");
+ verifyFormat("<T extends B> T getInstance(Class<T> type);");
}
TEST_F(FormatTestJava, StringConcatenation) {
More information about the cfe-commits
mailing list