[PATCH] Improve Windows toolchain support for non-standard environments.

Zachary Turner zturner at google.com
Thu Oct 30 12:54:16 PDT 2014


This has been submitted

================
Comment at: lib/Driver/Tools.cpp:7825
@@ +7824,3 @@
+    llvm::sys::path::append(VSDir, Exe);
+    if (llvm::sys::fs::can_execute(VSDir.c_str()))
+      return VSDir.str();
----------------
hans wrote:
> nit: I'd just use VSDir.str(). Same for FilePath below.
I did use VSDir.str(), did you mean you'd just use VSDir?  Won't compile, there's no implicit conversion from SmallString to Twine.

http://reviews.llvm.org/D5845






More information about the cfe-commits mailing list