Fwd: patch for warning on logical negation with known result

[jahanian]

- Ping.

- Thanks, Fairborz


> Begin forwarded message:
> 
> Subject: Re: patch for warning on logical negation with known result
> From: jahanian <fjahanian at apple.com>
> Date: October 24, 2014 at 2:08:10 PM PDT
> To: Richard Trieu <rtrieu at google.com>
> Cc: cfe commits <cfe-commits at cs.uiuc.edu>
> 
> Minor change. I should not bail out early when types of implicit cast and its sub expression are identical as
> implicit cast may be for lvalue to rvalue conversion. This showed up for this test case (with old patch warning is not being issued).
> 
> __attribute__((__nonnull__))
> void test1(void *nonnull) {
>    if (nonnull) {}
> }
> 
> 
> - Fariborz
> 
>> On Oct 24, 2014, at 1:23 PM, jahanian <fjahanian at apple.com <mailto:fjahanian at apple.com>> wrote:
>> 
>> Thanks for the review. Here is the updated patch.
>> 
>> 	
>> <nonnull-patch.txt>
>> 
>> - Fariborz
>> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141029/04d98019/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nonnull-patch-2.txt
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141029/04d98019/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141029/04d98019/attachment-0001.html>