[PowerPC ABI] Bug 21398 - Consider C++ base classes in homogeneous aggregate classification

Hal Finkel hfinkel at anl.gov
Wed Oct 29 05:52:04 PDT 2014


----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: "cfe-commits cfe" <cfe-commits at cs.uiuc.edu>
> Sent: Tuesday, October 28, 2014 12:29:09 PM
> Subject: [PowerPC ABI] Bug 21398 - Consider C++ base classes in homogeneous	aggregate classification
> 
> 
> 
> Hello,
> 
> as discussed in Bug 21398, PowerPC ABI code currently ignores C++
> base
> classes when classifying a class as homogeneous aggregate (or not)
> for ABI
> purposes.  The attached patch fixes this.
> 
> Tested on powerpc64le-linux.  Also ran GCC's ABI compatibility test
> suite
> against clang with no new failures (unfortunately, it didn't catch
> the
> bug).
> 
> OK for mainline?

LGTM, thanks!

 -Hal

> 
> (See attached file: diff-clang-ppc64le-baseclass-abifix)
> 
> 
> Mit freundlichen Gruessen / Best Regards
> 
> Ulrich Weigand
> 
> --
>   Dr. Ulrich Weigand | Phone: +49-7031/16-3727
>   STSM, GNU/Linux compilers and toolchain
>   IBM Deutschland Research & Development GmbH
>   Vorsitzende des Aufsichtsrats: Martina Koederitz |
>   Geschäftsführung: Dirk
> Wittkopp
>   Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht
> Stuttgart, HRB 243294
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory




More information about the cfe-commits mailing list