[PATCH] Adding 4 ASTMatchers: typedefDecl, isInMainFile, isInSystemFile, isInFileMatchingName

Hendrik von Prince raise.rescue at gmail.com
Sun Oct 26 10:36:04 PDT 2014


isExpansionInMainFile and isExpansionInFileMatching - sounds reasonable :)
I'm going with FileContentMappings for now, but feel free to change anytime - I'm not enthusiastic about names.
I included Tooling.h in PreprocessorOptions.h to have access to the new typedef FileContentMappings. It feels kinda heavy to add that include for one typedef only. Furthermore, I'm unsure how to update the description of the RemappedFiles, as it directly relates to the std::pair that is now no longer visible in the typename. In my eyes, the usage of std::pair now becomes to an implementation-detail that should not be exposed in the comment, so i removed these mentions.

http://reviews.llvm.org/D4283

Files:
  include/clang/ASTMatchers/ASTMatchers.h
  include/clang/Lex/PreprocessorOptions.h
  include/clang/Tooling/Tooling.h
  lib/ASTMatchers/Dynamic/Registry.cpp
  lib/Tooling/Tooling.cpp
  unittests/ASTMatchers/ASTMatchersTest.cpp
  unittests/ASTMatchers/ASTMatchersTest.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4283.15460.patch
Type: text/x-patch
Size: 11811 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141026/b9b83df0/attachment.bin>


More information about the cfe-commits mailing list