lgtm ================ Comment at: test/CodeGenCXX/dllexport.cpp:608 @@ -609,1 +607,3 @@ +// Don't create weak dllexport aliases. +struct NonExportedBaseClass { ---------------- Maybe put the PR number in the comment as well. http://reviews.llvm.org/D5986