patch for warning on logical negation with known result

jahanian fjahanian at apple.com
Fri Oct 24 14:08:10 PDT 2014


Minor change. I should not bail out early when types of implicit cast and its sub expression are identical as
implicit cast may be for lvalue to rvalue conversion. This showed up for this test case (with old patch warning is not being issued).

__attribute__((__nonnull__))
void test1(void *nonnull) {
   if (nonnull) {}
}


- Fariborz

> On Oct 24, 2014, at 1:23 PM, jahanian <fjahanian at apple.com> wrote:
> 
> Thanks for the review. Here is the updated patch.
> 
> 	
> <nonnull-patch.txt>
> 
> - Fariborz
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141024/c17943f8/attachment.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nonnull-patch-2.txt
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141024/c17943f8/attachment.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141024/c17943f8/attachment-0001.html>


More information about the cfe-commits mailing list