[Patch] Add C++14 feature querying macro `cxx_digit_separators` describing support for "Single-Quotation-Mark as a Digit Separator"

Michel Morin mimomorin at gmail.com
Thu Oct 23 07:44:27 PDT 2014


Richard Smith wrote:
> The patch looks good to me, but I have a more general question before we go
> ahead with this: should we continue to add Clang-specific __has_feature
> tests for features that are covered by C++'s SD-6 feature test
> recommendations?
[...]
> ... and there seems to be no reason for portable code to use __has_feature
> for this check.

Ah, I didn't realize that Clang has implemented SD-6 feature-test macros.
(I'll update Clang's config in Boost.Config to use them.)

So it makes sense to provide only SD-6 macros. But, for C++14 features,
I would think having __has_feature macros would be better. For TS and C++1z
features, I don't think it's necessary to provide __has_feature macros.

Patch for __cpp_digit_separators attached.


Regards,
Michel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cpp_digit_separators.patch
Type: application/octet-stream
Size: 1066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141023/d0dd3615/attachment.obj>


More information about the cfe-commits mailing list