[PATCH] Make a good guess about where MSVC and Windows SDK libraries are for linking.

Hans Wennborg hans at chromium.org
Wed Oct 22 13:34:40 PDT 2014


lgtm2

================
Comment at: lib/Driver/MSVCToolChain.cpp:237
@@ +236,3 @@
+      // It is not necessary to link against Windows SDK 7.x when targeting ARM.
+      libPath.clear();
+      return false;
----------------
Clearing this seems redundant?

================
Comment at: lib/Driver/MSVCToolChain.cpp:243
@@ +242,3 @@
+  } else {
+    // Windows SDK 8.x installs libraries in an folder whose names depend on
+    // the version of the OS you're targeting.  By default choose the newest,
----------------
nit: s/an/a/, s/names/name/ ?

================
Comment at: lib/Driver/MSVCToolChain.cpp:247
@@ +246,3 @@
+    // the SDK on.
+    char *tests[] = {"winv6.3", "win8", "win7"};
+    bool found = false;
----------------
is winv6.3 newer than win8? (i have no idea, just noticed the number is lower)

http://reviews.llvm.org/D5873






More information about the cfe-commits mailing list