r220032 - D5775: The new test case was missing from the preceding commit.

[NAKAMURA Takumi]

It's fine. Thanks!

2014-10-20 21:22 GMT+09:00 Evgeny Astigeevich <evgeny.astigeevich at arm.com>:
> Hi Nakamura,
>
> I will modify the second test case as follows:
>
> Index: test/Layout/itanium-union-bitfield.cpp
> ===================================================================
> --- test/Layout/itanium-union-bitfield.cpp      (revision 220189)
> +++ test/Layout/itanium-union-bitfield.cpp      (working copy)
> @@ -9,7 +9,7 @@
>  A::A() {}
>
>  union B {
> -  int f1: 69;
> +  char f1: 35;
>    B();
>  };
>
> @@ -24,6 +24,6 @@
>  // CHECK:*** Dumping AST Record Layout
>  // CHECK-NEXT:   0 | union B
>  // CHECK-NEXT:   0 |   int f1
> -// CHECK-NEXT:     | [{{sizeof=16, dsize=9, align=8|sizeof=12, dsize=9,
> align=4}}
> -// CHECK-NEXT:     |  {{nvsize=9, nvalign=8|nvsize=9, nvalign=4}}]
> +// CHECK-NEXT:     | [sizeof=8, dsize=5, align=4
> +// CHECK-NEXT:     |  nvsize=5, nvalign=4]
>
>
> This will work as well as for 64- and 32-bit platforms.
>
>
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of NAKAMURA Takumi
> Sent: 19 October 2014 19:57
> To: Artyom Skrobov
> Cc: cfe-commits
> Subject: Re: r220032 - D5775: The new test case was missing from the
> preceding commit.
>
> Seems it's incompatible to i686. Appeased in r220166.
>
> Could you re-tweak to satisfy i686-unknown-unknown?
>
> 2014-10-17 19:25 GMT+09:00 Artyom Skrobov <Artyom.Skrobov at arm.com>:
>> Author: askrobov
>> Date: Fri Oct 17 05:25:09 2014
>> New Revision: 220032
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=220032&view=rev
>> Log:
>> D5775: The new test case was missing from the preceding commit.
>>
>> Added:
>>     cfe/trunk/test/Layout/itanium-union-bitfield.cpp
>>
>> Added: cfe/trunk/test/Layout/itanium-union-bitfield.cpp
>> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Layout/itanium-union-bitf
> ield.cpp?rev=220032&view=auto
>>
> ============================================================================
> ==
>> --- cfe/trunk/test/Layout/itanium-union-bitfield.cpp (added)
>> +++ cfe/trunk/test/Layout/itanium-union-bitfield.cpp Fri Oct 17 05:25:09
> 2014
>> @@ -0,0 +1,29 @@
>> +// RUN: %clang_cc1 -emit-llvm-only -triple %itanium_abi_triple
> -fdump-record-layouts %s 2>/dev/null \
>> +// RUN:            | FileCheck %s
>> +
>> +union A {
>> +  int f1: 3;
>> +  A();
>> +};
>> +
>> +A::A() {}
>> +
>> +union B {
>> +  int f1: 69;
>> +  B();
>> +};
>> +
>> +B::B() {}
>> +
>> +// CHECK:*** Dumping AST Record Layout
>> +// CHECK-NEXT:   0 | union A
>> +// CHECK-NEXT:   0 |   int f1
>> +// CHECK-NEXT:     | [sizeof=4, dsize=1, align=4
>> +// CHECK-NEXT:     |  nvsize=1, nvalign=4]
>> +
>> +// CHECK:*** Dumping AST Record Layout
>> +// CHECK-NEXT:   0 | union B
>> +// CHECK-NEXT:   0 |   int f1
>> +// CHECK-NEXT:     | [sizeof=16, dsize=9, align=8
>> +// CHECK-NEXT:     |  nvsize=9, nvalign=8]
>> +
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
>