[PATCH] [clang-tidy] Add support for custom configuration file names/formats.

Alexander Kornienko alexfh at google.com
Mon Oct 20 05:39:25 PDT 2014


================
Comment at: clang-tidy/ClangTidyOptions.cpp:183
@@ -173,3 +182,3 @@
     if (!Result)
-      Result = TryReadConfigFile(CurrentPath);
+        Result = TryReadConfigFile(CurrentPath);
 
----------------
djasper wrote:
> indentation
Done.

================
Comment at: clang-tidy/ClangTidyOptions.h:144
@@ +143,3 @@
+  /// return llvm::make_unique<FileOptionsProvider>(GlobalOptions,
+  ///     DefaultOptions, OverrideOptions, ConfigHandlers);
+  /// \endcode
----------------
djasper wrote:
> It seems complicated to have to specify all of GlobalOptions, DefaultOptions and OverrideOptions. Consider adding overloads or something.
> 
> nit: indentation ;-)
For the use case we have, these all parameters are essential. We can add more overloads once we have a specific need.

http://reviews.llvm.org/D5821






More information about the cfe-commits mailing list