[PATCH] [libcxx] Add support for building and testing with an ABI library not along linker paths

Dan Albert danalbert at google.com
Fri Oct 17 17:59:53 PDT 2014


Just a few small changes.

================
Comment at: test/lit.cfg:380
@@ +379,3 @@
+        self.link_flags += ['-L' + self.obj_root + '/lib']
+        self.link_flags += ('-L' + l for l in lpaths)
+        # Configure libraries
----------------
I don't think you meant to make this one a tuple.

================
Comment at: www/index.html:442
@@ +441,3 @@
+  <!--=====================================================================-->
+    <p>
+        <strong>Note: This is not recommended in almost all cases.</strong>
----------------
Indentation mismatch.

================
Comment at: www/index.html:451
@@ +450,3 @@
+        linker can find.  If you want to build and test libc++ against an ABI
+        library not in the linkers path you need to set
+        <code>-DCMAKE_LIBRARY_PATH=/path/to/abi/lib</code> when configuring
----------------
linker's

http://reviews.llvm.org/D5038






More information about the cfe-commits mailing list