[PATCH] Improve Windows toolchain support for non-standard environments.

Zachary Turner zturner at google.com
Fri Oct 17 11:28:12 PDT 2014


Hi rnk, aaron.ballman, hans,

    Typically clang finds Visual Studio by the user explicitly setting
    up a Visual Studio environment via vcvarsall.  But we still try to
    behave intelligently and fallback to different methods of finding
    Visual Studio when this is not done.  This patch improves various
    fallback codepaths to make Visual Studio locating more robust.

    Specifically, this patch:

    * Adds support for searching environment variables for VS 12.0
    * Correctly locates include folders for Windows SDK 8.x (this was
      previously broken, and would cause clang to error).  Windows
      SDK 8.x segregates its includes into \shared, \um, and \winrt.
    * Prefers locating link.exe in the same location as cl.exe.  This
      is helpful in case another link.exe is in the path earlier than
      Visual Studio (e.g. GnuWin32)
    * Minor cleanup in the registry reading code to make it more
      robust in the presence of long pathnames.

http://reviews.llvm.org/D5845

Files:
  lib/Driver/ToolChains.h
  lib/Driver/Tools.cpp
  lib/Driver/WindowsToolChain.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5845.15088.patch
Type: text/x-patch
Size: 16203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141017/710be069/attachment.bin>


More information about the cfe-commits mailing list